handle heterogeneous arrays in flattening pass by tim-hoffman · Pull Request #660 · project-llzk/llzk-lib

tim-hoffman · 2026-07-30T19:52:19Z

Summary

Update flattening pass to create a series of flattened structs for an array of heterogeneous structs.

Related issues

Fixes #296

tim-hoffman · 2026-07-30T19:55:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c9383a7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2026-07-30T20:17:53Z

Test Results

2 files ± 0 2 suites ±0 6m 48s ⏱️ +30s
427 tests +31 423 ✅ +31 4 💤 ±0 0 ❌ ±0
854 runs +62 846 ✅ +62 8 💤 ±0 0 ❌ ±0

Results for commit 123bafa. ± Comparison against base commit 683c6d4.

♻️ This comment has been updated with latest results.

tim-hoffman · 2026-07-31T01:15:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf4ba11ae4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-07-31T02:14:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 44d8aafd08

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-12T17:12:34Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0414c2294

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-12T19:36:20Z

@codex review

chatgpt-codex-connector

💡 Codex Review

llzk-lib/lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Lines 1964 to 1969 in bf67a58

    
           Block &newTemplateBody = newTemplate.getBodyRegion().front(); 
        
           for (Attribute name : layout.remainingNames) { 
        
             FlatSymbolRefAttr nameSym = llvm::cast<FlatSymbolRefAttr>(name); 
        
             Operation *paramOp = symTables.getSymbolTable(parentTemplate).lookup(nameSym.getAttr()); 
        
             assert(paramOp && "symbol must exist"); 
        
             newTemplateBody.push_back(paramOp->clone());

Preserve sibling callees in partial templates

When the partially instantiated function contains a flat call to a sibling function in the original template, the cloned template contains only the remaining parameters, copied expressions, and newFunc; it does not contain that sibling. The flat callee consequently resolves relative to the new template and becomes an unknown symbol, so applyBodyConversions() rejects an otherwise valid partial instantiation. Copy referenced sibling functions recursively or rewrite such callees to a path that still resolves in the original template.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

it already has a failure though

tim-hoffman · 2026-08-12T22:36:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 755ef86fa9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-08-13T14:45:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

llzk-lib/lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Lines 5105 to 5106 in 31655b6

    
           ArrayType newType = createResultType.cloneWith(newResultElemType); 
        
           rewriter.modifyOpInPlace(op, [&createResult, &newType]() { createResult.setType(newType); });

Validate array users before refining initializer-driven types

When a member-read refinement changes every array.new initializer to a concrete type, this mutation updates the array SSA value globally without checking consumers of that array. A generic array can initially be passed to a call expecting array<Cell<1>>, while its generic initializer is later refined to Cell<0> by another member write; this branch changes the argument to array<Cell<0>>, and no propagation pattern updates the callee parameter, leaving the call invalid. Check the array value's typed consumers before committing the initializer-driven element refinement.

llzk-lib/lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Lines 1513 to 1515 in 31655b6

    
           replaceOpWithNewOp<ExtractArrayOp>( 
        
               rewriter, op, newResultTy, adaptor.getArrRef(), adaptor.getIndices() 
        
           );

Preserve attributes when converting wildcard array reads

When function instantiation resolves a wildcard scalar element to an array, this replacement creates an ExtractArrayOp without copying the original ReadArrayOp's discardable attributes. An annotated read therefore loses metadata such as product_source specifically along the new scalar-to-ranged conversion path; transfer the source read's discardable attribute dictionary to the replacement.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Pull request overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

include/llzk/Dialect/Polymorphic/Transforms/TransformationPasses.td:62

This documentation names poly.const_read, but the registered operation is poly.read_const (include/llzk/Dialect/Polymorphic/IR/Ops.td:236). Use the actual operation spelling so users can find and invoke it.

    - Replace instantiated `poly.const_read` uses, symbolic member table

test/Transforms/Flattening/test/Transforms/Flattening/member_read_array_initializer_reproducer.llzk:1

This test was added under a duplicated test/Transforms/Flattening directory hierarchy, unlike the other flattening tests. Move it to test/Transforms/Flattening/member_read_array_initializer_reproducer.llzk so the suite layout and reported test path remain consistent.

+    }
+  }
+  return success();


tim-hoffman added 2 commits July 30, 2026 14:46

add constant folding for applymap op

68c97a5

changelog

5291572

chatgpt-codex-connector Bot reviewed Jul 30, 2026

View reviewed changes

tim-hoffman added 2 commits July 30, 2026 15:03

handle heterogeneous arrays in flattening pass

f932193

changelog

e4dfcc5

tim-hoffman force-pushed the th/296 branch from 74c9383 to e4dfcc5 Compare July 30, 2026 20:03

tim-hoffman added 3 commits July 30, 2026 15:24

fix: Preserve table offsets on split member reads

1d17f85

fix: Preserve source attributes on replacement member writes

19e1af8

fix: Refresh dependent candidates after replacing array reads

21226c2

Base automatically changed from th/applymap_folding to main July 31, 2026 00:40

tim-hoffman added 5 commits July 30, 2026 19:40

handle heterogeneous arrays in flattening pass

cb1c312

changelog

f23fc2a

fix: Preserve table offsets on split member reads

a299cab

fix: Preserve source attributes on replacement member writes

3324cdc

fix: Refresh dependent candidates after replacing array reads

ff91cdd

tim-hoffman force-pushed the th/296 branch from 21226c2 to ff91cdd Compare July 31, 2026 00:40

tim-hoffman added 3 commits July 30, 2026 20:14

Merge branch 'th/296' of github.com:project-llzk/llzk-lib into th/296

bd54be7

fix: Reject members with writers that cannot be split

2dba2bf

handle cases of unwritten values

bf4ba11

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

tim-hoffman added 4 commits July 30, 2026 20:49

fix: Seed scalar values from inline array initializers

54cc999

fix: Keep scalar member reads at the original read point

70fab49

fix: Allow expandable arrays to populate multiple split members

50b341e

fix: Preserve metadata on replacement member reads

44d8aaf

chatgpt-codex-connector Bot reviewed Jul 31, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

fix: Copy discardable attributes to split member definitions

935e0a9

tim-hoffman added 2 commits August 12, 2026 11:38

fix: Preserve external observations when refining direct writes

a341d08

fix: Guard array initializers before refining member reads

eb70755

project-llzk deleted a comment from chatgpt-codex-connector Bot Aug 12, 2026

add test for: Materialize shared unifiable casts before split writes

c0414c2

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp Outdated

tim-hoffman added 5 commits August 12, 2026 12:39

fix: Preflight local read consumers before rewriting candidates

dfe3d1a

clang-tidy

b42cb2b

fix: Validate every member target before retagging casts

4a28b9b

fix: Preserve per-element write attributes on scalar writes

3d6c216

combine duplicate code

bf67a58

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

fix: Preserve sibling callees in partial templates

29df055

tim-hoffman force-pushed the th/296 branch from 83f3c0d to 29df055 Compare August 12, 2026 21:54

add test: Validate return consumers before refining member reads

755ef86

it already has a failure though

chatgpt-codex-connector Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

tim-hoffman and others added 3 commits August 13, 2026 09:15

fix: Validate unifiable-cast consumers before replacing reads

795b5bc

fix: Check array writes before refining member reads

228d575

Merge branch 'main' into th/296

31655b6

chatgpt-codex-connector Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

tim-hoffman added 4 commits August 13, 2026 10:20

fix: Compute shared read refinements before replacing users

c1c4169

fix: Validate array users before refining initializer-driven types

000ce43

fix: Preserve attributes when converting wildcard array reads

cefdb3b

fix: Preflight expandable read consumers before rewriting

123bafa

tim-hoffman requested a balanced review from Copilot August 13, 2026 18:42

Copilot started reviewing on behalf of tim-hoffman August 13, 2026 18:42 View session

Copilot AI reviewed Aug 13, 2026

View reviewed changes

Comment thread lib/Dialect/Polymorphic/Transforms/FlatteningPass.cpp

Comment on lines +2758 to +2760

}

}

return success();

	Block &newTemplateBody = newTemplate.getBodyRegion().front();
	for (Attribute name : layout.remainingNames) {
	FlatSymbolRefAttr nameSym = llvm::cast<FlatSymbolRefAttr>(name);
	Operation *paramOp = symTables.getSymbolTable(parentTemplate).lookup(nameSym.getAttr());
	assert(paramOp && "symbol must exist");
	newTemplateBody.push_back(paramOp->clone());

	ArrayType newType = createResultType.cloneWith(newResultElemType);
	rewriter.modifyOpInPlace(op, [&createResult, &newType]() { createResult.setType(newType); });

	replaceOpWithNewOp<ExtractArrayOp>(
	rewriter, op, newResultTy, adaptor.getArrRef(), adaptor.getIndices()
	);

Uh oh!

Conversation

tim-hoffman commented Jul 30, 2026

Summary

Related issues

Uh oh!

tim-hoffman commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

tim-hoffman commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Jul 31, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

tim-hoffman commented Aug 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

tim-hoffman commented Aug 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

github-actions Bot commented Jul 30, 2026 •

edited

Loading